activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From qihongxu <...@git.apache.org>
Subject [GitHub] activemq-artemis issue #2482: ARTEMIS-2214 Cache durable&priority in PagedRe...
Date Fri, 04 Jan 2019 07:34:09 GMT
Github user qihongxu commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2482
  
    > Im very cautious of optimising for one case
    > Its very unusual for consumers to go away as it is good design in most mom a consumer
is long lived. Like wise upgrade is a non normal event.
    > 
    > So without priority removed im -1 this. As i stated in an ideal world everything
in paging would be off heap, we shouldnt just end up with every value in page ref, else we
lose the reason for paging originals intent which is to remove the message from heap at penalty
that it will be slower. If you want faster add more ram so more can be kept on heap.
    
    Not adding priority is acceptable since it's rare. I will later remove the priority part.
    And how about deliveryTime? It's already in PageRef and might need to be set in the constructor.


---

Mime
View raw message