activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2484: ARTEMIS-2216 Use a specific executor fo...
Date Thu, 03 Jan 2019 18:48:23 GMT
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2484#discussion_r245095523
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
---
    @@ -1350,7 +1350,7 @@ public synchronized boolean hasNext() {
                 return true;
              }
     
    -         if (!pageStore.isPaging()) {
    +         if (!pageStore.isPagingDirtyRead()) {
    --- End diff --
    
    Concern here is this ins't an async case.
    
    Btw i cannot see the change in QueueImpl to use the new paging dirty read.


---

Mime
View raw message