activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From CNNJYB <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2483: ARTEMIS-2215 largemessage have been con...
Date Thu, 03 Jan 2019 11:47:50 GMT
Github user CNNJYB commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2483#discussion_r244976446
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
---
    @@ -309,16 +309,17 @@ public void run() {
         */
        @Override
        protected void performCachedLargeMessageDeletes() {
    -      for (Long largeMsgId : largeMessagesToDelete) {
    -         SequentialFile msg = createFileForLargeMessage(largeMsgId, LargeMessageExtension.DURABLE);
    +      for (LargeServerMessage largeServerMessage : largeMessagesToDelete.values()) {
    --- End diff --
    
    @michaelandrepearce update, please review, Thanks.


---

Mime
View raw message