activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2483: ARTEMIS-2215 largemessage have been con...
Date Wed, 02 Jan 2019 15:01:51 GMT
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2483#discussion_r244757759
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
---
    @@ -309,16 +309,17 @@ public void run() {
         */
        @Override
        protected void performCachedLargeMessageDeletes() {
    -      for (Long largeMsgId : largeMessagesToDelete) {
    -         SequentialFile msg = createFileForLargeMessage(largeMsgId, LargeMessageExtension.DURABLE);
    +      for (LargeServerMessage largeServerMessage : largeMessagesToDelete.values()) {
    --- End diff --
    
    If you wish the collection itself to be iterable, then please add this functionality to
LongConcurrentHashMap implementation, it shouldn;t be too hard, as already it has a forEach
method


---

Mime
View raw message