activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer
Date Sat, 26 Jan 2019 02:28:26 GMT
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to
queueQuery on producer
URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251182656
 
 

 ##########
 File path: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageProducer.java
 ##########
 @@ -393,57 +395,18 @@ private void doSendx(ActiveMQDestination destination,
          if (defaultDestination == null) {
             throw new UnsupportedOperationException("Destination must be specified on send
with an anonymous producer");
          }
-
          destination = defaultDestination;
-      } else {
-         if (defaultDestination != null) {
-            if (!destination.equals(defaultDestination)) {
-               throw new UnsupportedOperationException("Where a default destination is specified
" + "for the sender and a destination is " + "specified in the arguments to the send, " +
"these destinations must be equal");
-            }
+      } else if (defaultDestination != null) {
+         if (!destination.equals(defaultDestination)) {
+            throw new UnsupportedOperationException("Where a default destination is specified
" + "for the sender and a destination is " + "specified in the arguments to the send, " +
"these destinations must be equal");
          }
+      } else {
+         session.checkDestination(destination);
 
          address = destination.getSimpleAddress();
 
 Review comment:
   back on a proper pc,
   
   i was meaning only:
            address = destination.getSimpleAddress();
    
   if defaultdestination != null, then don't need to do session.checkDestination(destination),
as we checked the destination already when we created the message producer
   
   
   doesn't matter too much as connection.containsKnownDestination(address) should return true
anyhow, meaning it avoids the expensive bit. 
   
   **Im still happy with PR to merge, just a comment**
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message