activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] clebertsuconic commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer
Date Fri, 25 Jan 2019 16:24:54 GMT
clebertsuconic commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery
on producer
URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251045430
 
 

 ##########
 File path: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java
 ##########
 @@ -397,6 +380,55 @@ public MessageProducer createProducer(final Destination destination)
throws JMSE
       }
    }
 
+   void checkDestination(ActiveMQDestination destination) throws JMSException {
 
 Review comment:
   TBH I hate final methods...
   
   I have needed quite a few times to override them on test cases... so I only reserve the
word final where there is a strong "business" case to not let it be overwritten.  but that's
jut my opinion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message