activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] clebertsuconic commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.
Date Thu, 24 Jan 2019 18:48:08 GMT
clebertsuconic commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor
leak under SM due to lack of privileged block.
URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250732153
 
 

 ##########
 File path: artemis-commons/src/main/java/org/apache/activemq/artemis/core/server/NetworkHealthCheck.java
 ##########
 @@ -157,7 +157,12 @@ public NetworkHealthCheck parseURIList(String addressList) {
 
    @Override
    protected ActiveMQThreadFactory getThreadFactory() {
-      return new ActiveMQThreadFactory("NetworkChecker", "Network-Checker-", false, getThisClassLoader());
 
 Review comment:
   This is just creating a ThreadFactory.. is it really needed?
   
   I would expect a security check around new Threads, but against a new ActiveMQThreadFactory?

   
   are you sure about it? just checking it's not a typo?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message