activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] michaelandrepearce commented on a change in pull request #2432: [ARTEMIS-2176] RA connection properties are not propagated to XARecov…
Date Thu, 24 Jan 2019 06:44:13 GMT
michaelandrepearce commented on a change in pull request #2432: [ARTEMIS-2176] RA connection
properties are not propagated to XARecov…
URL: https://github.com/apache/activemq-artemis/pull/2432#discussion_r250482029
 
 

 ##########
 File path: artemis-service-extensions/src/main/java/org/apache/activemq/artemis/service/extensions/xa/recovery/XARecoveryConfig.java
 ##########
 @@ -45,16 +45,41 @@
    private final Map<String, String> properties;
    private final ClientProtocolManagerFactory clientProtocolManager;
 
+   // ServerLocator properties
 
 Review comment:
   This is really ba duplication, it simply will be a nightmare to keep this in sync as we
add more and too brittle. A better solution has to exist, even if it’s some work to abstract


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message