activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] franz1981 edited a comment on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods
Date Tue, 22 Jan 2019 06:38:24 GMT
franz1981 edited a comment on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties
and cleanupInternalProperties methods
URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-456287327
 
 
   > Just test core message in isolation franz. If an internal header is not present it
will not iterate through
   
   I agree for adhoc unit tests, but common core exchanges include common headers that are
wrongly considered "internal" ie they start with `_AMQ_`, making `internalProperties = true`
and triggering cleaning up that won't clean anything, given that the `internal properties`
are indeed more specific.
   I like your PR (but shocked by GitHUB THB), but I was concerned by the amount of checks
to be performed every time a new property is added and the real cost to matain that flag consistent:
the original version wasn't considering cases where properties are removed/cleared etc etc:
in that case how much is consistent that flag?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message