activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] michaelandrepearce edited a comment on issue #2509: NO-JIRA Fix Possible NPE in connectToNodeInReplicatedCluster
Date Fri, 18 Jan 2019 23:26:38 GMT
michaelandrepearce edited a comment on issue #2509: NO-JIRA Fix Possible NPE in connectToNodeInReplicatedCluster
URL: https://github.com/apache/activemq-artemis/pull/2509#issuecomment-455719841
 
 
   This showed up in static analysis, technically because of the try catch(exception) , this
would be caught and wouldnt cause issue. But as the trace line above we ensure is null safe,
and like wise we null safe the getB varient it would be good to clean up. 
   
   Also this can be opportunity to dedupe some code, moving it to a method.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message