activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] michaelandrepearce edited a comment on issue #2490: ARTEMIS-196 Implement Consumer Priority
Date Wed, 16 Jan 2019 17:18:44 GMT
michaelandrepearce edited a comment on issue #2490: ARTEMIS-196 Implement Consumer Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454854944
 
 
   @clebertsuconic ok so i know whats going on, another feature i have implemented for 2.7.0
reset of message groups, the test i had created is a little over strict and tested exact current
behaviour, rather than what is just needed, that when resetting a message group, the selection
on the next consumer for that group would have been the next consumer that joined. Where as
actually when you reset the group in reality you just open the oppurtunity for another consumer
to take the group. 
   Because i have reworked this PR to make things more tidy and to abstract bits, during dispatch
we cycle through the consumers round robin, even if it was a consumer group, as such on group
reset it is the next current positioned consumer. 
   
   Im thinking i could add a repeat method to the iteration, so when a consumer it will repeat,
so return the same consumer, this would give same as before.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message