activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] michaelandrepearce commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management
Date Tue, 15 Jan 2019 11:58:01 GMT
michaelandrepearce commented on a change in pull request #2498: ARTEMIS-2228 Large Messages
over Management
URL: https://github.com/apache/activemq-artemis/pull/2498#discussion_r247864160
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java
 ##########
 @@ -1005,9 +1006,9 @@ public RemotingConnection getRemotingConnection() {
          ByteBuffer buffer = ByteBuffer.allocate(8);
          buffer.putLong(queue.getID());
          message.putBytesProperty(Message.HDR_ROUTE_TO_IDS, buffer.array());
-         postOffice.route(message, true);
+         server.getPostOffice().route(LargeServerMessageImpl.checkLargeMessage(message, server.getStorageManager()),
true);
 
 Review comment:
   Just FYI, the fix looks good, im just wondering if theres a better way, but if not then
this looks good.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message