activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] gemmellr commented on issue #2490: V2 196
Date Thu, 10 Jan 2019 11:50:28 GMT
gemmellr commented on issue #2490: V2 196
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-453069204
 
 
   @ Thanks. I'd still rather some of the tests weren't burning 250ms various times waiting
to test something that can be verified 'immediately', but its a lot better.
   
   I'm still not sure if you've seen this comment (github is hiding it as 'resolved') so I'll
copy it here:
   
   https://github.com/apache/activemq-artemis/pull/2490/files#r246398611
   > Does this comment cover to the bit around the safety of always sending the new additional
data even to old servers? I can't tell if its covered.
   >
   > I think it should at the very least be commented what/when the encoding+decoding handling
behaviour changed so folks can understand the implications later without heading to find past
commits.
   
   
   which was related to part of an earlier comment https://github.com/apache/activemq-artemis/pull/2490/files#r245955337),
mostly:
   > Also, is the reverse case safe, does an older server failing to read the additional
value (seemingly always sent now) have potential to lead to any issues on older servers, i.e
how might the buffer continue to be used later if at all? Should the client omit the value
for older servers? (Or does the presumed version change prevent the new client working with
the old server anyway? I don't know how that stuff is handled, just commenting from reading
the diff here).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message