activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbertram <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2470: Fixes for alerts from lgtm.com
Date Wed, 19 Dec 2018 21:12:14 GMT
Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2470#discussion_r243076837
  
    --- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/PrintData.java
---
    @@ -216,63 +216,63 @@ private static void printPages(DescribeJournal describeJournal,
     
              if (pgStore != null) {
                 folder = pgStore.getFolder();
    --- End diff --
    
    The not-null check here on `pgStore` indicates that `pgStore` may, in fact, be null. If
it is null then it will trigger a `NullPointerException` almost straight away.


---

Mime
View raw message