activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2466: ARTEMIS-2206 The MQTT consumer reconnec...
Date Tue, 18 Dec 2018 13:46:31 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2466#discussion_r242541448
  
    --- Diff: artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTSubscriptionManager.java
---
    @@ -194,12 +191,13 @@ private synchronized void removeSubscription(String address) throws
Exception {
           SimpleString internalQueueName = getQueueNameForTopic(internalAddress);
           session.getSessionState().removeSubscription(address);
     
    -
    -      ServerConsumer consumer = consumers.get(address);
    +      Set<Consumer> queueConsumers = session.getServer().queueConsumersQuery(internalQueueName);
    --- End diff --
    
    I think this is wrong. You should only check for consumers on this Session.
    
    Your logic is closing every consumer to the same address. You keep multiple connections
and you have a failure.


---

Mime
View raw message