activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franz1981 <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2434: ARTEMIS-1867 FQQN for producers
Date Thu, 06 Dec 2018 15:10:39 GMT
Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2434#discussion_r239488173
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/BindingsImpl.java
---
    @@ -53,7 +54,13 @@
     
        private final Map<SimpleString, Integer> routingNamePositions = new ConcurrentHashMap<>();
     
    -   private final Map<Long, Binding> bindingsMap = new ConcurrentHashMap<>();
    +   private final Map<Long, Binding> bindingsIdMap = new ConcurrentHashMap<>();
    +
    +   /**
    +    * This is the same as bindingsIdMap but indexed on the binding's uniqueName rather
than ID. Two maps are
    +    * maintained to speed routing, otherwise we'd have to loop through the bindingsIdMap
when routing to an FQQN.
    +    */
    +   private final Map<SimpleString, Binding> bindingsNameMap = new ConcurrentHashMap<>();
    --- End diff --
    
    I'm not aware of the context here, but  considering that are used 2 different concurrent
maps I suppose that there is no chance that data would be different between them from a reader
pov right?
    If not I suppose that's fine


---

Mime
View raw message