activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franz1981 <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2448: ARTEMIS-2189 allow deleting temp dest w...
Date Thu, 06 Dec 2018 14:56:37 GMT
Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2448#discussion_r239482834
  
    --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java
---
    @@ -386,14 +386,27 @@ public void setSimpleAddress(SimpleString address) {
     
        public void delete() throws JMSException {
           if (session != null) {
    +         ActiveMQSession sessionToUse = session;
    +         boolean temporary = false;
              if (session.getCoreSession().isClosed()) {
    -            // Temporary queues will be deleted when the connection is closed.. nothing
to be done then!
    -            return;
    +            /**
    --- End diff --
    
    @tabish121 The updated version is fine mate? If is fine I will merge it :+1: 


---

Mime
View raw message