activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franz1981 <...@git.apache.org>
Subject [GitHub] activemq-artemis issue #2449: ARTEMIS-2191 Makes PostOfficeImpl::route commo...
Date Thu, 06 Dec 2018 13:23:57 GMT
Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2449
  
    > It seems yours is a refactoring while mine had functionality involved.. hence I'm
asking you to defer it
    
    Yep, got it :+1: 
    
    > Adding your change in top of mine added failues (the one you sent).
    
    I see 2 reasons for that:
    
    - the context::clear that I have added is wrong
    - there are other cases where we need to clear the context that are not correct handled
(due 2 my changes!)
    
    - 


---

Mime
View raw message