activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbertram <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2448: ARTEMIS-2189 allow deleting temp dest w...
Date Wed, 05 Dec 2018 02:18:55 GMT
Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2448#discussion_r238910671
  
    --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java
---
    @@ -386,14 +386,27 @@ public void setSimpleAddress(SimpleString address) {
     
        public void delete() throws JMSException {
           if (session != null) {
    +         ActiveMQSession sessionToUse = session;
    +         boolean temporary = false;
              if (session.getCoreSession().isClosed()) {
    -            // Temporary queues will be deleted when the connection is closed.. nothing
to be done then!
    -            return;
    +            /**
    --- End diff --
    
    Fair enough. I pushed an update.


---

Mime
View raw message