From dev-return-68219-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Mon Nov 26 13:02:57 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 30867180647 for ; Mon, 26 Nov 2018 13:02:57 +0100 (CET) Received: (qmail 92164 invoked by uid 500); 26 Nov 2018 12:02:56 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 92153 invoked by uid 99); 26 Nov 2018 12:02:55 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Nov 2018 12:02:55 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 601EDE125E; Mon, 26 Nov 2018 12:02:55 +0000 (UTC) From: amg077-motorolasolutions-com To: dev@activemq.apache.org Reply-To: dev@activemq.apache.org Message-ID: Subject: [GitHub] activemq-cpp pull request #8: Update PlatformThread.cpp Content-Type: text/plain Date: Mon, 26 Nov 2018 12:02:55 +0000 (UTC) GitHub user amg077-motorolasolutions-com opened a pull request: https://github.com/apache/activemq-cpp/pull/8 Update PlatformThread.cpp Added handling thread creation failure when _beginthreadex() returns (uintptr_t )-1L. See MSDN: https://msdn.microsoft.com/en-us/library/kdzttdcb.aspx for details. Added errno and _doserrno to exception message. Reason: PlatformThread::createNewThread() is a public method. Developer who uses this method expects, that it is enough to catch an exception and next apply usual null pointer checking. Value -1L is different than NULL so it would cause memory access violation on de-reference. You can merge this pull request into a Git repository by running: $ git pull https://github.com/amg077-motorolasolutions-com/activemq-cpp master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-cpp/pull/8.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #8 ---- commit 9a05fa756390bd3bcddc19d2ee242078dcde5938 Author: amg077-motorolasolutions-com <45261601+amg077-motorolasolutions-com@...> Date: 2018-11-26T08:59:06Z Update PlatformThread.cpp Added handling thread creation failure when _beginthreadex() returns (uintptr_t )-1L. See MSDN: https://msdn.microsoft.com/en-us/library/kdzttdcb.aspx for details. Added errno and _doserrno to exception message. Reason: PlatformThread::createNewThread() is a public method. Developer who uses this method expects, that it is enough to catch an exception and next apply usual null pointer checking. Value -1L is different than NULL so it would cause memory access violation on de-reference. commit a8eeadb1a61b1880653cf755799590c9e615da80 Author: amg077-motorolasolutions-com <45261601+amg077-motorolasolutions-com@...> Date: 2018-11-26T09:35:36Z Merge pull request #1 from amg077-motorolasolutions-com/amg077-motorolasolutions-com-patch-1 Update PlatformThread.cpp ---- ---