activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franz1981 <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...
Date Tue, 20 Nov 2018 10:15:33 GMT
Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2427#discussion_r234941860
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
---
    @@ -52,6 +52,11 @@
      *  consumers */
     public class CoreMessage extends RefCountMessage implements ICoreMessage {
     
    +   // We use properties to establish routing context on clustering.
    +   // However if the client resends the message after receiving, it needs to be removed
    +   private static final Predicate<SimpleString> INTERNAL_PROPERTY_NAMES_CLEANUP_FILTER
=
    --- End diff --
    
    Good catch!
    I'm looking from the tablet so I hope to have searched all the interesting points, but
it seems to me that HDR_ROUTE_TO_ACK_IDS is not needed anymore? Or am I missing anything?
    `Message.HDR_ROUTE_TO_IDS.concat(bridgeName);` is using HDR_ROUTE_TO_IDS in a way that
it will match the `CoreMessage::cleanupInternalProperties` cases, but for HDR_ROUTE_TO_ACK_IDS
I can't see any points doing anything similar: just using the entire property name ie it won't
match the  `CoreMessage::cleanupInternalProperties` checks.


---

Mime
View raw message