activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From spyrkob <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2432: [ARTEMIS-2176] RA connection properties...
Date Thu, 15 Nov 2018 14:31:32 GMT
Github user spyrkob commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2432#discussion_r233862871
  
    --- Diff: artemis-service-extensions/src/main/java/org/apache/activemq/artemis/service/extensions/xa/recovery/XARecoveryConfig.java
---
    @@ -45,16 +45,41 @@
        private final Map<String, String> properties;
        private final ClientProtocolManagerFactory clientProtocolManager;
     
    +   // ServerLocator properties
    --- End diff --
    
    @clebertsuconic I was trying to make them available in createServerLocator() so that I
can apply them to new instances of ServerLocator. Would it be better to hold a reference to
original locator/factory instead? Or is there a better way to pass those properties I missed?


---

Mime
View raw message