activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbertram <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2434: ARTEMIS-1867 FQQN for producers
Date Thu, 15 Nov 2018 14:08:39 GMT
Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2434#discussion_r233854063
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
---
    @@ -3178,138 +3187,7 @@ public Queue createQueue(final SimpleString address,
                                 final int consumersBeforeDispatch,
                                 final long delayBeforeDispatch,
                                 final boolean autoCreateAddress) throws Exception {
    -      return createQueue(address, routingType, queueName, filterString, user, durable,
temporary, ignoreIfExists, transientQueue, autoCreated, maxConsumers, purgeOnNoConsumers,
exclusive, lastValue, lastValueKey, nonDestructive, consumersBeforeDispatch, delayBeforeDispatch,
autoCreateAddress, false);
    -   }
    -
    -   private Queue createQueue(final SimpleString address,
    --- End diff --
    
    There were two different but nearly identical implementations of createQueue(). I consolidated
these into a single method. There should be no semantic differences.


---

Mime
View raw message