activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...
Date Sun, 11 Nov 2018 15:03:46 GMT
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2427#discussion_r232491039
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
---
    @@ -803,52 +802,45 @@ public CoreMessage setDurable(boolean durable) {
        @Override
        public CoreMessage putBooleanProperty(final String key, final boolean value) {
           messageChanged();
    -      checkProperties();
    -      properties.putBooleanProperty(SimpleString.toSimpleString(key, getPropertyKeysPool()),
value);
    +      checkProperties().putBooleanProperty(SimpleString.toSimpleString(key, getPropertyKeysPool()),
value);
           return this;
        }
     
        @Override
        public CoreMessage putBooleanProperty(final SimpleString key, final boolean value)
{
           messageChanged();
    -      checkProperties();
    -      properties.putBooleanProperty(key, value);
    +      checkProperties().putBooleanProperty(key, value);
           return this;
        }
     
        @Override
        public Boolean getBooleanProperty(final SimpleString key) throws ActiveMQPropertyConversionException
{
    -      checkProperties();
    -      return properties.getBooleanProperty(key);
    +      return checkProperties().getBooleanProperty(key);
        }
     
        @Override
        public Boolean getBooleanProperty(final String key) throws ActiveMQPropertyConversionException
{
    -      checkProperties();
    -      return properties.getBooleanProperty(SimpleString.toSimpleString(key, getPropertyKeysPool()));
    +      return checkProperties().getBooleanProperty(SimpleString.toSimpleString(key, getPropertyKeysPool()));
    --- End diff --
    
    Delegate to simplestring method 


---

Mime
View raw message