activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2376: [ARTEMIS-2130]Web console display blank...
Date Wed, 24 Oct 2018 00:31:22 GMT
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2376#discussion_r227609704
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConnectionView.java
---
    @@ -91,7 +95,14 @@ public Object getField(RemotingConnection connection, String fieldName)
{
              case "protocol":
                 return connection.getProtocolName();
              case "clientID":
    -            return connection.getClientID();
    +            String clientID = null;
    +            for (ServerSession session : sessions) {
    +               if (clientID == null) {
    +                  clientID = session.getMetaData("jms-client-id") == null ? connection.getClientID()
: session.getMetaData("jms-client-id");
    --- End diff --
    
    jms specifics should not be in core broker. Also this is the connection view, this data
is off the session view, so should be visible there, not on the connection. 


---

Mime
View raw message