activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2384: ARTEMIS-2141 Add Filter column to Consu...
Date Wed, 24 Oct 2018 00:16:43 GMT
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2384#discussion_r227607588
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConsumerView.java
---
    @@ -89,6 +90,8 @@ public Object getField(ServerConsumer consumer, String fieldName) {
                 return consumer.getQueueName();
              case "queueType":
                 return consumer.getQueueType();
    +         case "filter":
    +            return consumer.getFilter() == null ? "" : consumer.getFilter().getFilterString();
    --- End diff --
    
    Rather than the dupe logic here and on line 61, create a method to getFilterString.
    
    Also if null, should return null, not empty string.
             return filter != null ? filter.getFilterString().toString() : null;
    
    e.g. should be same logic as in QueueControlImpl 
    



---

Mime
View raw message