activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2371: ARTEMIS-2097 Pause and Block Producers
Date Mon, 15 Oct 2018 13:30:42 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2371#discussion_r225165274
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java
---
    @@ -1789,6 +1790,11 @@ public synchronized RoutingStatus doSend(final Transaction tx,
     
           AddressInfo art = getAddressAndRoutingType(new AddressInfo(msg.getAddressSimpleString(),
routingType));
     
    +      if (postOffice.isAddressBlocked(msg.getAddressSimpleString())) {
    --- End diff --
    
    I think the use case here is wrong. With block you just stop sending credits to the client.
    
    This becomes fail at this point.
    
    We have two options:
    
    
    - If you had previously sent credits to the client.. then you must complete the operations
until you have full credits.
    
    - or we could hung to these on the server. But that would have a risk of running OME.
So I would say we just stop sending credits.


---

Mime
View raw message