activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2338: ARTEMIS-2101 Do not cluster OpenWire ad...
Date Tue, 02 Oct 2018 14:56:09 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2338#discussion_r221985696
  
    --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireProtocolManager.java
---
    @@ -154,6 +154,11 @@ public OpenWireProtocolManager(OpenWireProtocolManagerFactory factory,
ActiveMQS
           if (cc != null) {
              cc.addClusterTopologyListener(this);
           }
    +      if (supportAdvisory) {
    --- End diff --
    
    I wouldn't make it dependent on supportAdvisory.
    
    Say you have two acceptors.. different IPs.. you will have this called twice.
    
    I would always add the filter, and check if the filter is not part of the expression before
you called it.


---

Mime
View raw message