activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franz1981 <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2338: ARTEMIS-2101 Do not cluster OpenWire ad...
Date Mon, 01 Oct 2018 09:00:15 GMT
Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2338#discussion_r221536659
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionBridge.java
---
    @@ -350,6 +352,8 @@ private String appendIgnoresToFilter(String filterString) {
           filterString += "!" + storeAndForwardPrefix;
           filterString += ",!" + managementAddress;
           filterString += ",!" + managementNotificationAddress;
    +      //advisory topics shouldn't be clustered
    +      filterString += ",!" + ADVISORY_TOPIC_PREFIX;
    --- End diff --
    
    The best wat I could think is to inject it as a constructor parameter similar to managementNotificationAddress;
but advisory topics are just an OpenWire specific feature anyway


---

Mime
View raw message