From dev-return-67160-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Sun Sep 9 15:47:00 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C8388180671 for ; Sun, 9 Sep 2018 15:46:59 +0200 (CEST) Received: (qmail 90342 invoked by uid 500); 9 Sep 2018 13:46:58 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 90329 invoked by uid 99); 9 Sep 2018 13:46:58 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 09 Sep 2018 13:46:58 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id C790DDFF41; Sun, 9 Sep 2018 13:46:57 +0000 (UTC) From: alechenninger To: dev@activemq.apache.org Reply-To: dev@activemq.apache.org Message-ID: Subject: [GitHub] activemq pull request #297: AMQ-7050: Allow alternate persistence mechanism ... Content-Type: text/plain Date: Sun, 9 Sep 2018 13:46:57 +0000 (UTC) GitHub user alechenninger opened a pull request: https://github.com/apache/activemq/pull/297 AMQ-7050: Allow alternate persistence mechanism with SubQueueSelectorCacheBrokerPlugin More details in JIRA. Had a go at this by pulling out an interface for cache interactions and including default, File-based implementation that behaves just as before. This flexibility is designed to allow future, alternative implementations such as a JDBC-based cache (e.g. for folks using JDBC persistence). Thanks for review! You can merge this pull request into a Git repository by running: $ git pull https://github.com/alechenninger/activemq AMQ-7050 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq/pull/297.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #297 ---- commit ba9090eb5d39614cc03a3359fc1f775e9351e54f Author: Alec Henninger Date: 2018-09-08T19:32:14Z Pull out interface for SubQueueSelectorCache persistence commit 8150674e15c2fe7af5a5776571577aa73c5bb362 Author: Alec Henninger Date: 2018-09-08T19:47:30Z Remove bad import; add back default-to-empty-set behavior commit 102ff18d0fe4c9a7b54ceb2b8f7ff4263eec25e5 Author: Alec Henninger Date: 2018-09-08T20:54:32Z Properly remove all selector on removeConsumer with single selector commit 460ba12fb610ffa04a1be00f850de617f6205348 Author: Alec Henninger Date: 2018-09-09T12:09:37Z Make interface easier to implement correctly commit 83f5c72dd39a35c8df26f0c164af63f34995224e Author: Alec Henninger Date: 2018-09-09T13:09:21Z Only lookup selectors if debug logging enabled commit 955e21cae13517e41c0ff59941674f6818a5dc03 Author: Alec Henninger Date: 2018-09-09T13:09:28Z Use try-with-resources commit 6a1357cde588eb41e1a18dfe27ec9d27d41d5c0e Author: Alec Henninger Date: 2018-09-09T13:22:04Z Add javadoc, make sure returned set is not mutable per interface commit f8bacdd430913cd627bea2b6953842d996d3a283 Author: Alec Henninger Date: 2018-09-09T13:26:18Z Javadoc PeriodicallyFlushedFileSubSelectorCache ---- ---