From dev-return-67288-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Wed Sep 19 11:45:43 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 87FF2180621 for ; Wed, 19 Sep 2018 11:45:42 +0200 (CEST) Received: (qmail 436 invoked by uid 500); 19 Sep 2018 09:45:41 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 425 invoked by uid 99); 19 Sep 2018 09:45:40 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Sep 2018 09:45:40 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 945CAE005E; Wed, 19 Sep 2018 09:45:40 +0000 (UTC) From: wy96f To: dev@activemq.apache.org Reply-To: dev@activemq.apache.org Message-ID: Subject: [GitHub] activemq-artemis pull request #2324: ARTEMIS-2092 fix first page messages lo... Content-Type: text/plain Date: Wed, 19 Sep 2018 09:45:40 +0000 (UTC) GitHub user wy96f opened a pull request: https://github.com/apache/activemq-artemis/pull/2324 ARTEMIS-2092 fix first page messages lost on server crash bug Reproduction steps: 1. Send messages(using non transactional session), ensure the queue enters page mode and only one page is created. 2. Kill -9 server process or crash server. 3. Start the server and we find that page created in step 1 is deleted. Messages in the page are lost. When server starts, we should set empty flag of pageSubscription to false if pendingCounter record is loaded to prevent cleanup process from deleting the page. You can merge this pull request into a Git repository by running: $ git pull https://github.com/wy96f/activemq-artemis first_page_messages_lost Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2324.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2324 ---- commit 3028969c049a5e9b4d2b772efa16920a6e6ccb90 Author: yang wei Date: 2018-09-19T09:42:02Z ARTEMIS-2092 fix first page messages lost on server crash bug ---- ---