From dev-return-67220-archive-asf-public=cust-asf.ponee.io@activemq.apache.org  Thu Sep 13 15:32:35 2018
Return-Path: <dev-return-67220-archive-asf-public=cust-asf.ponee.io@activemq.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 48407180649
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 13 Sep 2018 15:32:35 +0200 (CEST)
Received: (qmail 43052 invoked by uid 500); 13 Sep 2018 13:32:34 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 43039 invoked by uid 99); 13 Sep 2018 13:32:33 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Sep 2018 13:32:33 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 45A48DFC65; Thu, 13 Sep 2018 13:32:33 +0000 (UTC)
From: clebertsuconic <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-2305-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-2305-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #2305: NO-JIRA - Page.write() should throw exc...
Content-Type: text/plain
Message-Id: <20180913133233.45A48DFC65@git1-us-west.apache.org>
Date: Thu, 13 Sep 2018 13:32:33 +0000 (UTC)

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2305#discussion_r217384203
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/Page.java ---
    @@ -223,7 +223,7 @@ private int read(StorageManager storage, ActiveMQBuffer fileBuffer, List<PagedMe
     
        public synchronized void write(final PagedMessage message) throws Exception {
           if (!file.isOpen()) {
    -         return;
    +         throw new IllegalStateException("can't write to closed file " + file);
    --- End diff --
    
    ok.. I think you should throw a proper exception, extending ActiveMQException:
    
    ActiveMQIOErrorException would be perfect there.


---