activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franz1981 <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2181: ARTEMIS-1980 Warn on failed check of ta...
Date Fri, 28 Sep 2018 12:00:40 GMT
Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2181#discussion_r221229493
  
    --- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
---
    @@ -227,7 +227,11 @@ private void createTableIfNotExists(String tableName, String... sqls)
throws SQL
                       }
                    }
                 } catch (SQLException e) {
    -               logger.warn(JDBCUtils.appendSQLExceptionDetails(new StringBuilder("Can't
verify the initialization of table ").append(tableName).append(" due to:"), e, sqlProvider.getCountJournalRecordsSQL()));
    +               if (logger.isDebugEnabled()) {
    +                  logger.debug(JDBCUtils.appendSQLExceptionDetails(new StringBuilder("Can't
verify the initialization of table ").append(tableName).append(" due to:"), e, sqlProvider.getCountJournalRecordsSQL()));
    +               } else {
    +                  logger.infof("Can't verify the initialization of table %s", tableName);
    --- End diff --
    
    @clebertsuconic There is anything I need to do in order to get it merged mate?


---

Mime
View raw message