activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2307: ARTEMIS-2070 broker can reduce buffer c...
Date Wed, 12 Sep 2018 16:11:17 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2307#discussion_r217096333
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientMessageImpl.java
---
    @@ -400,17 +398,10 @@ public long getLargeBodySize() {
           }
     
           @Override
    -      public int encode(final ByteBuffer bufferRead) throws ActiveMQException {
    -         ActiveMQBuffer buffer1 = ActiveMQBuffers.wrappedBuffer(bufferRead);
    -         return encode(buffer1, bufferRead.capacity());
    -      }
    -
    -      @Override
    -      public int encode(final ActiveMQBuffer bufferOut, final int size) {
    --- End diff --
    
    I'm trying to understand why this was removed? I'm not saying it's wrong.. just trying
to understand it. Can  you explain?


---

Mime
View raw message