From dev-return-66999-archive-asf-public=cust-asf.ponee.io@activemq.apache.org  Wed Aug 29 17:47:23 2018
Return-Path: <dev-return-66999-archive-asf-public=cust-asf.ponee.io@activemq.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id D5CDB180657
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 29 Aug 2018 17:47:22 +0200 (CEST)
Received: (qmail 50837 invoked by uid 500); 29 Aug 2018 15:47:21 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 50819 invoked by uid 99); 29 Aug 2018 15:47:21 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Aug 2018 15:47:21 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id C9551DFB1A; Wed, 29 Aug 2018 15:47:20 +0000 (UTC)
From: cshannon <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-2278-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-2278-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis issue #2278: ARTEMIS-2052 Fixing initial credit negotiation
Content-Type: text/plain
Message-Id: <20180829154720.C9551DFB1A@git1-us-west.apache.org>
Date: Wed, 29 Aug 2018 15:47:20 +0000 (UTC)

Github user cshannon commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2278
  
    The issue is here: https://github.com/apache/activemq-artemis/blob/106e71bdf4f1cf7ddf0dfc37ce6bab76d5c00dad/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/ConsumerWindowSizeTest.java#L1457
    
    That line should now change to: assertTrue(Wait.waitFor(() -> cons.getAvailableCredits().get() == consumer.getClientWindowSize() * 2, 5000, 500));
    
    And that will fix it


---