From dev-return-66878-archive-asf-public=cust-asf.ponee.io@activemq.apache.org  Mon Aug 20 23:41:18 2018
Return-Path: <dev-return-66878-archive-asf-public=cust-asf.ponee.io@activemq.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 7A431180677
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 20 Aug 2018 23:41:17 +0200 (CEST)
Received: (qmail 50186 invoked by uid 500); 20 Aug 2018 21:41:16 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 50175 invoked by uid 99); 20 Aug 2018 21:41:15 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Aug 2018 21:41:15 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id B115EDFB1B; Mon, 20 Aug 2018 21:41:15 +0000 (UTC)
From: clebertsuconic <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-2254-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-2254-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...
Content-Type: text/plain
Message-Id: <20180820214115.B115EDFB1B@git1-us-west.apache.org>
Date: Mon, 20 Aug 2018 21:41:15 +0000 (UTC)

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2254#discussion_r211416478
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java ---
    @@ -241,6 +243,16 @@
        // ClientSession implementation
        // -----------------------------------------------------------------
     
    +   @Override
    +   public boolean isEnable1xPrefixes() {
    +      return enable1XPrefixes;
    +   }
    +
    +   @Override
    +   public void setEnable1xPrefixes(boolean value) {
    --- End diff --
    
    @michaelandrepearce also, notice this is only affecting the default on ActiveMQConnectionFactory...
    
    There the value is also settable.


---