From dev-return-66711-archive-asf-public=cust-asf.ponee.io@activemq.apache.org  Fri Aug 10 18:17:46 2018
Return-Path: <dev-return-66711-archive-asf-public=cust-asf.ponee.io@activemq.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 9F2B6180630
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 10 Aug 2018 18:17:45 +0200 (CEST)
Received: (qmail 61553 invoked by uid 500); 10 Aug 2018 16:17:44 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 61542 invoked by uid 99); 10 Aug 2018 16:17:43 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Aug 2018 16:17:43 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id D4E44DFB1B; Fri, 10 Aug 2018 16:17:43 +0000 (UTC)
From: michaelandrepearce <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-2237-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-2237-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...
Content-Type: text/plain
Message-Id: <20180810161743.D4E44DFB1B@git1-us-west.apache.org>
Date: Fri, 10 Aug 2018 16:17:43 +0000 (UTC)

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2237#discussion_r209312787
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java ---
    @@ -711,6 +712,32 @@ public long countMessages(final String filterStr) throws Exception {
           }
        }
     
    +   @Override
    +   public String countMessagesProperty(final String filter) throws Exception {
    --- End diff --
    
    Look at FilterImpl.createFilter to create the filter.


---