activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gemmellr <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2274: ARTEMIS-2059 NettyWritable should use U...
Date Thu, 30 Aug 2018 15:20:27 GMT
Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2274#discussion_r214073404
  
    --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/util/NettyWritable.java
---
    @@ -106,7 +105,8 @@ public void put(ByteBuf payload) {
     
        @Override
        public void put(String value) {
    -      nettyBuffer.writeCharSequence(value, StandardCharsets.UTF_8);
    --- End diff --
    
    Any string encoded by proton-j will use the method. The broker tries not to encode things
for AMQP->AMQP cases however so a lot of the time it wont be used at all. The rest of the
time, it is specifically using an expanding buffer as it doesn't know the size of whats being
encoded.


---

Mime
View raw message