activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franz1981 <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2274: ARTEMIS-2059 NettyWritable should use U...
Date Thu, 30 Aug 2018 15:05:22 GMT
Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2274#discussion_r214067838
  
    --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/util/NettyWritable.java
---
    @@ -106,7 +105,8 @@ public void put(ByteBuf payload) {
     
        @Override
        public void put(String value) {
    -      nettyBuffer.writeCharSequence(value, StandardCharsets.UTF_8);
    --- End diff --
    
    @clebertsuconic AFAIK this is happening on Core, but with AMQP the Strings are UTF-8 encoded
using `WritableBuffer::put(String)`.
    I'm not 100% sure of it: @gemmellr do you know for what it is used `WritableBuffer::put(String)`?


---

Mime
View raw message