activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2274: ARTEMIS-2059 NettyWritable should use U...
Date Tue, 28 Aug 2018 16:14:34 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2274#discussion_r213379239
  
    --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/util/NettyWritable.java
---
    @@ -106,7 +105,8 @@ public void put(ByteBuf payload) {
     
        @Override
        public void put(String value) {
    -      nettyBuffer.writeCharSequence(value, StandardCharsets.UTF_8);
    --- End diff --
    
    utf8Bytes will make calculations to send Strings.
    This is at least changing the wire. 
    
    Basically we value performance with less UTf8 calculations.. sending pairs for strings,
right? or am I missing something?
    
    
    I'm worried about this also breaking string compatibiility.


---

Mime
View raw message