activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...
Date Mon, 20 Aug 2018 22:27:45 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2254#discussion_r211427175
  
    --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessage.java
---
    @@ -423,7 +421,7 @@ public Destination getJMSDestination() throws JMSException {
              SimpleString address = message.getAddressSimpleString();
              SimpleString name = address;
     
    -         if (address != null & enable1xPrefixes) {
    +         if (address != null & session.isEnable1xPrefixes()) {
    --- End diff --
    
    @michaelandrepearce  you made a comment I can't find on the web interface here. could
only see on email.
    
    ```
    Eg the jms connection or jms session
    ```
    
    The Resource Adapter will not have reference to the JMS Session in the same way. CoreSession
is the only way to do it.
    
    The other possibility would be to use a metadata, but I did not want to trust a hashmap
operation everytime this was called.


---

Mime
View raw message