activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...
Date Mon, 20 Aug 2018 22:06:32 GMT
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2254#discussion_r211422507
  
    --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessage.java
---
    @@ -423,7 +421,7 @@ public Destination getJMSDestination() throws JMSException {
              SimpleString address = message.getAddressSimpleString();
              SimpleString name = address;
     
    -         if (address != null & enable1xPrefixes) {
    +         if (address != null & session.isEnable1xPrefixes()) {
    --- End diff --
    
    I got that this is better but tbh the commit that added thay change was merged fairly
rapidly too. And once we relesse we get stuck with it. So rather we tidy up as much as possible
now.


---

Mime
View raw message