activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...
Date Mon, 20 Aug 2018 21:58:54 GMT
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2254#discussion_r211420562
  
    --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessage.java
---
    @@ -371,7 +369,7 @@ public Destination getJMSReplyTo() throws JMSException {
                 String name = address.toString();
     
                 // swap the old prefixes for the new ones so the proper destination type
gets created
    -            if (enable1xPrefixes) {
    +            if (session.isEnable1xPrefixes()) {
    --- End diff --
    
    The more invasive all these changes just for support of 1.x (isnt that the point of the
major version change to signal breaking changes)
    
    Would it maybe better to have a 1x jms client module, that has all these bits in so users
on 2.0.x dont get affected and also then keeps it all a bit more clean room


---

Mime
View raw message