activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...
Date Mon, 20 Aug 2018 21:35:43 GMT
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2254#discussion_r211415126
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java
---
    @@ -241,6 +243,16 @@
        // ClientSession implementation
        // -----------------------------------------------------------------
     
    +   @Override
    +   public boolean isEnable1xPrefixes() {
    +      return enable1XPrefixes;
    +   }
    +
    +   @Override
    +   public void setEnable1xPrefixes(boolean value) {
    --- End diff --
    
    Does this need to be changable? Could this not just be set in constructor and field made
final. As later the check is on hot path.


---

Mime
View raw message