activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2249: ARTEMIS-2023 Fix NPE
Date Tue, 14 Aug 2018 16:45:28 GMT
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2249#discussion_r210023905
  
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/StoreConfigTest.java
---
    @@ -289,6 +294,107 @@ public void testCreateQueue() throws Exception {
           jmsServer.stop();
        }
     
    +   @Test
    +   public void testCompatibilityWith260() {
    +      List<String> transportConfigurations = new ArrayList<>();
    +      transportConfigurations.add("tst");
    +      ConnectionFactoryConfigurationImpl configuration = (ConnectionFactoryConfigurationImpl)
new ConnectionFactoryConfigurationImpl();
    +      configuration.setName("np").setConnectorNames(transportConfigurations);
    +
    +      ByteBuffer buffer = ByteBuffer.allocate(configuration.getEncodeSize());
    +      ActiveMQBuffer activeMQBuffer = new ChannelBufferWrapper(Unpooled.wrappedBuffer(buffer));
    +      activeMQBuffer.clear();
    +      encodeVersion260(activeMQBuffer, configuration);
    +      configuration.decode(activeMQBuffer);
    +   }
    +
    +   public void encodeVersion260(final ActiveMQBuffer buffer, final ConnectionFactoryConfigurationImpl
connectionFactoryConfiguration) {
    --- End diff --
    
    Already noticed, Looks fine and dandy. Probably worth adding another version at some point
maybe after 2.6.3 to the versions to be compatibility checked, just as lots of recent serialisation
changes and additions


---

Mime
View raw message