activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2249: ARTEMIS-2023 Fix NPE
Date Tue, 14 Aug 2018 16:22:59 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2249#discussion_r210016740
  
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/StoreConfigTest.java
---
    @@ -289,6 +294,107 @@ public void testCreateQueue() throws Exception {
           jmsServer.stop();
        }
     
    +   @Test
    +   public void testCompatibilityWith260() {
    +      List<String> transportConfigurations = new ArrayList<>();
    +      transportConfigurations.add("tst");
    +      ConnectionFactoryConfigurationImpl configuration = (ConnectionFactoryConfigurationImpl)
new ConnectionFactoryConfigurationImpl();
    +      configuration.setName("np").setConnectorNames(transportConfigurations);
    +
    +      ByteBuffer buffer = ByteBuffer.allocate(configuration.getEncodeSize());
    +      ActiveMQBuffer activeMQBuffer = new ChannelBufferWrapper(Unpooled.wrappedBuffer(buffer));
    +      activeMQBuffer.clear();
    +      encodeVersion260(activeMQBuffer, configuration);
    +      configuration.decode(activeMQBuffer);
    +   }
    +
    +   public void encodeVersion260(final ActiveMQBuffer buffer, final ConnectionFactoryConfigurationImpl
connectionFactoryConfiguration) {
    --- End diff --
    
    BTW: I didn't say this. I thought it went without saying.. thanks a lot for pointing it
out!


---

Mime
View raw message