activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tabish121 <...@git.apache.org>
Subject [GitHub] activemq-nms-amqp pull request #2: AMQNET-575: NMS AMQP Client Rework
Date Fri, 03 Aug 2018 19:19:52 GMT
Github user tabish121 commented on a diff in the pull request:

    https://github.com/apache/activemq-nms-amqp/pull/2#discussion_r207643307
  
    --- Diff: src/main/csharp/ConnectionMetaData.cs ---
    @@ -0,0 +1,213 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +using System;
    +using System.Collections.Generic;
    +using System.Linq;
    +using System.Text;
    +using System.Threading.Tasks;
    +using Apache.NMS;
    +using System.Reflection;
    +using System.Diagnostics;
    +
    +namespace Apache.NMS.AMQP
    +{
    +    /// <summary>
    +    /// NMS.AMQP.ConnectionMetaData implements Apache.NMS.IConnectionMetaData
    --- End diff --
    
    I spotted a few places where the API docs have the wrong package names based on the latest
rounds of updates.  Since it isn't a real reference to a type it isn't as bad as it wouldn't
break any doc generator but would be nice for the reader if they all used the right name.


---

Mime
View raw message