From dev-return-66435-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Tue Jul 31 09:44:41 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C982C180662 for ; Tue, 31 Jul 2018 09:44:40 +0200 (CEST) Received: (qmail 44169 invoked by uid 500); 31 Jul 2018 07:44:39 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 44150 invoked by uid 99); 31 Jul 2018 07:44:39 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Jul 2018 07:44:39 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id E1159DFC43; Tue, 31 Jul 2018 07:44:38 +0000 (UTC) From: michaelandrepearce To: dev@activemq.apache.org Reply-To: dev@activemq.apache.org References: In-Reply-To: Subject: [GitHub] activemq-artemis pull request #2187: ARTEMIS-1545 Support JMS 2.0 Completion... Content-Type: text/plain Message-Id: <20180731074438.E1159DFC43@git1-us-west.apache.org> Date: Tue, 31 Jul 2018 07:44:38 +0000 (UTC) Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2187#discussion_r206424803 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java --- @@ -189,16 +185,24 @@ public void kill() { this.killed = true; } + private void setHandlers() { + sessionChannel.setCommandConfirmationHandler(commandConfirmationHandler); --- End diff -- This was meant to be either newer response handler or the older command confirm handler. The intent was both shouldn't be set. This may be the reason of your dupes issue, what was this needed still even with the async response change? ---