activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #2191: ARTEMIS-1987 - Add consumer window size...
Date Tue, 24 Jul 2018 14:47:54 GMT
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2191#discussion_r204785897
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java
---
    @@ -822,6 +833,20 @@ public void resetMetadata(HashMap<String, String> metaDataToSend)
{
           }
        }
     
    +   @Override
    +   public int getDefaultConsumerWindowSize(SimpleString address) throws ActiveMQException
{
    +      if (defaultConsumerWindowSize != null) {
    +         return defaultConsumerWindowSize;
    +      } else if (sessionChannel.supports(PacketImpl.SESS_CONS_WINDOW_SIZE_RESP, getServerVersion()))
{
    +         Packet packet = sessionChannel.sendBlocking(new ConsumerWindowSizeQueryMessage(address),
PacketImpl.SESS_CONS_WINDOW_SIZE_RESP);
    +         ConsumerWindowSizeQueryResponseMessage response = (ConsumerWindowSizeQueryResponseMessage)
packet;
    --- End diff --
    
    Could this not be returned in the create consumer response or address settings lookup,
to avoid extra calls. Imagine further defaults etc if everything was an individual request
it would bloat fast.


---

Mime
View raw message