activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tabish121 <...@git.apache.org>
Subject [GitHub] activemq-nms-amqp issue #2: AMQNET-575: NMS AMQP Client Rework
Date Tue, 10 Jul 2018 19:50:33 GMT
Github user tabish121 commented on the issue:

    https://github.com/apache/activemq-nms-amqp/pull/2
  
    It is generally best practice to squash commits into one on a PR to make life easier for
the reviews and to make the commit history simpler.  We don't really need to preserve a commit
removing files that shouldn't have been included in the first commit for instance.  


---

Mime
View raw message